Update for devices with height < 500px#17
Open
coderwassananmol wants to merge 1 commit intoss-javascript:masterfrom
Open
Update for devices with height < 500px#17coderwassananmol wants to merge 1 commit intoss-javascript:masterfrom
coderwassananmol wants to merge 1 commit intoss-javascript:masterfrom
Conversation
Member
|
Heyy @coderwassananmol In this commit, as far as I can see, you changed only Can I give you a little tip? Checking the line |
Contributor
Author
|
I think we don't require filterHeight this time. Since we are focusing on the popupHeight on whole to resize it according to the window, considering filterHeight should not make much of a difference. Well, I will still try locally and let you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3 Since, the
MAX_HEIGHTis set to500by default, problems in the devices with less than500pxheight will arise. So, in these devices there must be a workaround. I have added a check that verifies whether theMAX_HEIGHTis less than the window's height. If it is, then simply return theMAX_HEIGHT, else, return the window's height.