Maintenance: update --with-ldap detection#1736
Closed
yadij wants to merge 2 commits intosquid-cache:masterfrom
Closed
Maintenance: update --with-ldap detection#1736yadij wants to merge 2 commits intosquid-cache:masterfrom
yadij wants to merge 2 commits intosquid-cache:masterfrom
Conversation
rousskov
reviewed
Mar 13, 2024
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
I do not see any problems in this PR changes, but I do not know enough to do a thorough review. I hope that the time spent previously on removing Mozilla LDAP hacks (i.e. #1710 changes that are not present in this PR) was not wasted, and there will be a followup PR dedicated to that removal.
kinkie
previously approved these changes
Mar 14, 2024
yadij
force-pushed
the
arc-autoconf-ng-36
branch
from
0524581 to
4c6cc24
Compare
yadij
added
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Mar 18, 2024
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
rousskov
removed
the
S-could-use-an-approval
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Apr 9, 2024
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Apr 9, 2024
|
I'm having issues building Squid 7.1 on RHEL7 & RHEL8 I've raised https://bugs.squid-cache.org/show_bug.cgi?id=5513 I have a feeling it's caused by this change, but it doesn't revert cleanly |
Contributor
Thank you for posting a fix at #2267. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.