This repository was archived by the owner on Apr 29, 2020. It is now read-only.
Automatically delete a dangling RU when a there's a deploy attempt wi…#1136
Open
esuen wants to merge 1 commit intosquare:masterfrom
Open
Automatically delete a dangling RU when a there's a deploy attempt wi…#1136esuen wants to merge 1 commit intosquare:masterfrom
esuen wants to merge 1 commit intosquare:masterfrom
Conversation
Contributor
Author
|
I still gotta test this. |
ausmith
reviewed
Nov 5, 2019
| // There is an unknown reason where sometimes an RU still exists when it | ||
| // shouldn't. This deletes the dangling RU which is what we've been | ||
| // doing manually | ||
| err = s.Delete(ctx, conflictingErr.ConflictingID) |
Collaborator
There was a problem hiding this comment.
Shouldn't we check if there is only a single RC before deleting the RU blindly? 99% of the time I agree, but we have seen a couple where the RU is stuck because the RC is not at zero replicas.
Contributor
Author
There was a problem hiding this comment.
I believe this function only gets called when there’s only one RC. I can
double check later again, the name also suggests that this code path occurs
when there’s only one rc “...FromOneExistingRC”.
Collaborator
|
Pull latest from master to get tests able to run again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…th only one RC.