This repository was archived by the owner on Apr 29, 2020. It is now read-only.
Open
Conversation
esuen
reviewed
Mar 14, 2019
| } | ||
|
|
||
| for _, env := range args.Envs { | ||
| cmd = append(cmd, "env", env) |
Author
There was a problem hiding this comment.
No, we are using this way to modify the environment before executing a p2 hook launchable, and it works.
Collaborator
There was a problem hiding this comment.
Are these traditional environment variables that are being added or are these truly just additional arguments that happen to be similar in name? Examples of traditional environment variable usage from my perspective:
~ export ABC=123
~ command_that_uses_abc
# or
~ API_KEY=xxx my_awesome_command
Author
There was a problem hiding this comment.
the env here is for adding the traditional environment variables for the commands. like
~ my_awesome_command env API_KEY=xxx
which equals to:
~ API_KEY=xxx my_awesome_command
Collaborator
There was a problem hiding this comment.
So it is a custom argument that we turn into environment variables?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.