This repository was archived by the owner on Apr 29, 2020. It is now read-only.
Add test for docker environment variable behavior#1057
Open
mpuncel wants to merge 1 commit intosquare:masterfrom
Open
Add test for docker environment variable behavior#1057mpuncel wants to merge 1 commit intosquare:masterfrom
mpuncel wants to merge 1 commit intosquare:masterfrom
Conversation
spenceral
approved these changes
Jun 7, 2018
pkg/docker/docker_test.go
Outdated
| } | ||
|
|
||
| if !contains(envVars, "OVERRIDE=overridden") { | ||
| t.Error("expected to find OVERRIDE=overridden in teh environment variables because the launchable one should override the pod one, found %s", envVars) |
Collaborator
There was a problem hiding this comment.
Typo teh in each of the three error messages
esuen
reviewed
Jun 19, 2018
pkg/docker/docker_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
|
|
||
| err = ioutil.WriteFile(filepath.Join(podEnvDir, "OVERRIDE"), []byte("not_overridden"), 0755) |
Contributor
There was a problem hiding this comment.
nit: should these file permissions be 0644?
mpuncel
force-pushed
the
mpuncel/docker-test
branch
from
7102a62 to
c38291c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I felt bad about not writing tests so added some