This repository was archived by the owner on Apr 29, 2020. It is now read-only.
hook env: don't error if POD_UNIQUE_KEY is empty#1052
Open
mpuncel wants to merge 1 commit intosquare:masterfrom
Open
hook env: don't error if POD_UNIQUE_KEY is empty#1052mpuncel wants to merge 1 commit intosquare:masterfrom
mpuncel wants to merge 1 commit intosquare:masterfrom
Conversation
94ab9db to
52fb8a0
Compare
Collaborator
Author
|
hmm |
Collaborator
|
I'm having the same |
Contributor
|
In order to fix the Your errcheck in Rakefile should look like This is because errcheck was updated to selectively ignore functions in the |
POD_UNIQUE_KEY is empty for most pods, so it doesn't make sense to return an error if it's empty, just return an empty string
52fb8a0 to
adeb45f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POD_UNIQUE_KEY is empty for most pods, so it doesn't make sense to
return an error if it's empty, just return an empty string