Consider adding a curly bracket ("{}") check for the Key class#263
Open
hiroshi-ya wants to merge 2 commits intospyoungtech:mainfrom
Open
Consider adding a curly bracket ("{}") check for the Key class#263hiroshi-ya wants to merge 2 commits intospyoungtech:mainfrom
hiroshi-ya wants to merge 2 commits intospyoungtech:mainfrom
Conversation
For property DOWN and UP, do not add curly brackets if self is already braced by curly brackets
for more information, see https://pre-commit.ci
Owner
|
Thanks for this. Yeah, there's some known issues like this around the Likely, the keys module will be rewritten to support a more well-defined usage across various use cases. In the meantime, we can of course improve the current implementation. I'll submit a small review and will be happy to merge with those changes. |
spyoungtech
requested changes
Feb 24, 2024
Owner
spyoungtech
left a comment
There was a problem hiding this comment.
Just some small stylistic changes requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a project that allows its users to customize their key configurations. Here's a snippet:
Since key strings such as
'up'and'shift'need curly brackets ({}) when passed toahk.send(), I simply give a pair of curly brackets to theforwardKeystring no matter what they are (e.g.'a'becomes'{a}','up'becomes'{up}').Problem is, the
Key.DOWN/UPproperty also automatically adds a pair of curly brackets, e.g.:So, in the
move_forward()function,forwardKey == 'up', thenahk.send(forwardKey)will not work as expected (sends 'u' and 'p' instead of the up arrow key);forwardKey == '{up}', thenahk.key_down(forwardKey)will not work because it's equivalent toahk.send('{{up} down}').This PR aims to fix this issue - probably not very gracefully :/