Fixup JdbcIndexedSessionRepository - multiple sessions for ID #3638
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SessionResultSetExtractor#extractData should not return a list containing multiple entries for the same JdbcSession This is confusing when debugging the code. Add a warning when >1 session is found for the same ID. This is an indicator that data is corrupt; most of the schemas prevent at the database level by adding a unique constraint to the primary ID column. If the code encounters this scenario; it should fail fast, however this might be a breaking change. A WARN level logging helps developers initially spot this situation and remedy. Signed-off-by: Martin Ashby <martin@ashbysoft.com>
spring-projects-issues
added
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SessionResultSetExtractor#extractData should not return a list containing multiple entries for the same JdbcSession This is confusing when debugging the code.
Add a warning when >1 session is found for the same ID. This is an indicator that data is corrupt; most of the schemas prevent at the database level by adding a unique constraint to the primary ID column. If the code encounters this scenario; it should fail fast, however this might be a breaking change. A WARN level logging helps developers initially spot this situation and remedy.