This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Upgrade to Guava 21.0 (Java 8+ only)#16
Open
ldcasillas-progreso wants to merge 1 commit intospotify:masterfrom
Open
Upgrade to Guava 21.0 (Java 8+ only)#16ldcasillas-progreso wants to merge 1 commit intospotify:masterfrom
ldcasillas-progreso wants to merge 1 commit intospotify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a quick shot at upgrading the library to Guava 21.0 (Java 8+ only) to see how much work it would be, and it seems like it's very little effort. I make this pull request for your reference, since this would mean dropping support for Java 7 and earlier, I leave it to your discretion what's the right time for you guys to make this move.
(Some automatic IDE import rewrites snuck into the pull request.)