This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Getting script to work with /bin/sh#59
Open
jasonm-makerbot wants to merge 1 commit intospotify:masterfrom
Open
Getting script to work with /bin/sh#59jasonm-makerbot wants to merge 1 commit intospotify:masterfrom
jasonm-makerbot wants to merge 1 commit intospotify:masterfrom
Conversation
…ne or boot2docker
|
I can confirm that this works well inside of docker-machine -- there's nothing in the script that really "needs" bash. |
Contributor
|
Even if you change /bin/bash to /bin/sh, the script still contains some bashism: $ sudo dash docker-gc
docker-gc: 81: docker-gc: function: not found
$ sudo /bin/sh docker-gc
docker-gc: 81: docker-gc: function: not found
$ shellcheck docker-gc | grep -c -e 'SC.*:'
52 |
Member
|
There were functions added to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting script to work with /bin/sh so you can use it on docker-machine or boot2docker as they are minimal distributions that do not contain bash. The script still works when run by bash however.