Skip to content
This repository was archived by the owner on Feb 2, 2021. It is now read-only.

Exclude service images#171

Open
shyr wants to merge 1 commit intospotify:masterfrom
shyr:exclude_service_img
Open

Exclude service images#171
shyr wants to merge 1 commit intospotify:masterfrom
shyr:exclude_service_img

Conversation

@shyr
Copy link

@shyr shyr commented Jul 6, 2017

In docker swarm mode, keeping some images used by docker service could be better for those reasons.

  1. There is highly chance that the images is needed when service is updated and container should be run on the node.
  2. For some case like "drain node", docker rescheduling containers without sending registry auth. If there is no images on the node received message to run container by docker swarm, and the image need registry auth, the service would be fail.

This PR propose that if environment variable 'EXCLUDE_SERVICE_IMAGE' is true, docker-gc skip to clean images used by docker service.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant