Skip to content

Conversation

@chrisinmtown
Copy link
Contributor

Drop ineffective options section "[pytest]"

Drop ineffective options section "[pytest]"
@coveralls
Copy link

coveralls commented Oct 13, 2025

Coverage Status

coverage: 94.297%. remained the same
when pulling 3641d2a on chrisinmtown:correct-pytest-args
into aca6511 on spec-first:main.

@RobbeSneyders
Copy link
Member

@chrisinmtown
Copy link
Contributor Author

chrisinmtown commented Oct 13, 2025

The tests still seem to run fine though?

Yes the tests run. If I understand the pytest behavior correctly, it simply scans recursively for a directory named tests. Exactly one of those exists in this repo as of this commit, so the test workflows continue to function as expected. I first noticed the problem in my PR that offers a new directory in examples with a subdirectory tests and a file in there conftest.py. When pytest is allowed to scan the entire repo, it picks those up, and that little conftest.py file breaks the run. So I circled back to fix my botch here. Please consider.

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks for the explanation

@RobbeSneyders RobbeSneyders merged commit df9960b into spec-first:main Oct 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants