Abort migration if a given table refer by other tables using foreign key constraints#147
Open
vishal-jain wants to merge 1 commit intosoundcloud:masterfrom
Open
Abort migration if a given table refer by other tables using foreign key constraints#147vishal-jain wants to merge 1 commit intosoundcloud:masterfrom
vishal-jain wants to merge 1 commit intosoundcloud:masterfrom
Conversation
Abort migration if table refer by other tables using Foreign key constraints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original problem in issue #141 was that if we alter table having external constraints (i.e refer by other tables using foreign key constraints) using lhm. it modifies the table without any warning and errors and lhm uses a method of modification is copy table and rename strategy when lhm renames origin table that time all references get changed. In MySQL renaming of tables works like it changes all external references to a new_table so it causing an issue after migration runs. I have faced this issue as well
So in this pull request have just added validation it checks external foreign key constraints for given table and if it founds any table having references so it aborts the migration. Need of this validation till the time LHM/we provide any solution for rebuilding for foreign key constraints