MPT-18369: add helpdesk foundation with cases#218
Draft
svazquezco wants to merge 1 commit intomainfrom
Draft
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro 📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughAdds a Helpdesk resource to the client library: synchronous and asynchronous Helpdesk classes with CasesService/AsyncCasesService (including complete/process/query actions), exposes types via package init exports, and includes unit and end-to-end tests and test fixtures for cases. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/unit/resources/helpdesk/test_cases.py`:
- Around line 49-77: The test function test_custom_resource_actions_no_data (and
the similar no-data test later) declares an unused parameter input_status in the
pytest.mark.parametrize, causing ARG001; remove input_status from the param list
and from the parametrize tuples so only the action is parametrized (e.g. change
("action", "input_status") to ("action",) and provide ("process",), ("query",),
("complete",)), and update the corresponding pytest.mark.parametrize for the
other no-data test the same way so the test functions only accept the single
used argument and the unused parameter is eliminated.
ℹ️ Review info
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
mpt_api_client/mpt_client.pympt_api_client/resources/__init__.pympt_api_client/resources/helpdesk/__init__.pympt_api_client/resources/helpdesk/cases.pympt_api_client/resources/helpdesk/channels.pympt_api_client/resources/helpdesk/helpdesk.pytests/e2e/helpdesk/cases/test_async_cases.pytests/e2e/helpdesk/cases/test_sync_cases.pytests/e2e/helpdesk/channels/test_async_channels.pytests/e2e/helpdesk/channels/test_sync_channels.pytests/unit/resources/helpdesk/test_cases.pytests/unit/resources/helpdesk/test_channels.pytests/unit/resources/helpdesk/test_helpdesk.pytests/unit/test_mpt_client.py
svazquezco
force-pushed
the
codex/mpt-18369-helpdesk-foundation-channels-cases
branch
from
d18e10b to
336d5b5
Compare
svazquezco
force-pushed
the
codex/mpt-18369-helpdesk-foundation-channels-cases
branch
3 times, most recently
from
829acef to
1096816
Compare
svazquezco
changed the title
svazquezco
force-pushed
the
codex/mpt-18369-helpdesk-foundation-channels-cases
branch
from
1096816 to
256e648
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Codex-generated PR — Please review carefully.
Summary
helpdeskmodule scaffold with sync/async entrypoints onMPTClient/AsyncMPTClientcasesservice in this PRchannelsservice and related unit/e2e tests from this PRcreate,get,update, andfetch_page500)Validation
make checkmake test args="tests/unit/resources/helpdesk tests/unit/test_mpt_client.py"make test args="tests/e2e/helpdesk/cases/test_sync_cases.py tests/e2e/helpdesk/cases/test_async_cases.py"(2 passed, 6 skipped)Scope
Closes MPT-18369
MPTClientandAsyncMPTClientwith sync/async entrypointsHelpdeskandAsyncHelpdeskresource classes providing access to cases APICasesServiceandAsyncCasesServicesupporting collection, create, get, update, and custom actions (complete, process, query)Casemodel for the helpdesk cases resource with endpoint/public/v1/helpdesk/casesHelpdeskandAsyncHelpdesktypes inmpt_api_client.resources