Adds default, and various properties related to minimum and maximum#23
Open
JordiPolo wants to merge 7 commits intosoftprops:masterfrom
Open
Adds default, and various properties related to minimum and maximum#23JordiPolo wants to merge 7 commits intosoftprops:masterfrom
JordiPolo wants to merge 7 commits intosoftprops:masterfrom
Conversation
JordiPolo
changed the title
JordiPolo
commented
Nov 4, 2018
| serde_json = "1.0" | ||
| serde_yaml = "0.7" | ||
| error-chain = "0.10" | ||
| serde_yaml = "0.8" |
Contributor
Author
There was a problem hiding this comment.
No particular reason for these two. Newer is better I'd hope
softprops
reviewed
Nov 5, 2018
src/v2/schema.rs
Outdated
| fn from(item: PropertyDefault) -> Self { | ||
| match item { | ||
| PropertyDefault::Boolean(item) => item, | ||
| _ => true, |
Owner
There was a problem hiding this comment.
What do you think about using rusts defaults for these i.e. returning Default::default()? I'm also wondering if there's a better way to communicate this wasn't the type you thought it was. I.e. if you're defererning a string default as a book ect
Contributor
Author
There was a problem hiding this comment.
Good point, I'm using Default::default() now.
I did not understand the second part of your comment
…riant of ParameterOrRef instead of copying the structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready to merge
I was testing with some files and most of they failed because of something missing. I've added just what I need. One step at a time!