-
Notifications
You must be signed in to change notification settings - Fork 14
feat: common CLI dir checks in connectivity checker [IDE-1557] #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
I think this should be its own tool. It does not belong into the connectivity check. It actually should probably be implemented in LS, as this contains IDE logic. |
|
@bastiandoetsch Happy to move it to its own tool. |
I don't see why the user experience would be worse - if it lives in the LS repository, it would still be compiled into the CLI binary and could be used both from terminal and IDE. Or do I understand something wrong? Testing things from the IDE may be more valuable anyway, as environment shenanigans may not happen in the terminal, but within IDEs launched from the desktop directly, where launchd (or similar) don't inherit the shell environment. |
We have a customer who was having issue with the CLI download directories, this should help diagnose the problem. We can't have these directories be checked by just the LS (like I will do with delta scans having them be passed in the config to check), as it would be a chicken and egg problem. Although, giving it more thought while typing this, we could instruct customers to use a CLI binary in a temporary location for testing and then load the dirs from the IDE...
Additionally:
NODE_EXTRA_CA_CERTS,KRB5_CONFIG, andKRB5CCNAME.NODE_EXTRA_CA_CERTSis not mentioned in the docs, but is supported and even recommended by this tool itself.This is heavily vibe coded, so do fully scrutinise it.
The AI told me about the directory I labeled "Runtime Cache for Temporary Files", I haven't fully confirmed its actual use, but does indeed seem to be the cache dir for GAF.
If you would prefer this to be its own workflow and/or with a generic diagnostics workflow, then I can do that. I just didn't want to invest too much time into this before getting people's thoughts on it.
New output on MacOS
New output on Windows