Update halos module with main compatability updates.#630
Closed
itrharrison wants to merge 34 commits intomodule/halosfrom
Closed
Update halos module with main compatability updates.#630itrharrison wants to merge 34 commits intomodule/halosfrom
itrharrison wants to merge 34 commits intomodule/halosfrom
Conversation
…URL in dev environments (#597)
Co-authored-by: Ian Harrison <itrharrison@gmail.com>
Co-authored-by: Ian Harrison <itrharrison@gmail.com>
Co-authored-by: Ian Harrison <itrharrison@gmail.com>
…emplate (#609) * Update .readthedocs.yml to latest version in astropy package-template * Fix underline length * Add graphviz to apt_packages
* BLD: Upgrade checkout action to v4 * BLD: Upgrade setup-python action to v4 * BLD: Upgrade codecov-action to v3
5 tasks
Contributor
|
I'm going to close this and #632 - if tests relating to the power spectrum module (which the halos module depends on) are failing, then I think we should first try to fix the power spectrum module by bringing it up to date with main, then merge the power spectrum branch into halos. I started to have a look at this and will try to open a branch soon. However for now the CI for these PRs are running (and failing) on every update main which is not ideal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Fox's PR #614 the tests are failing on tests not touched by him. This is (at least) because of classy failing. This PR is to update the halos module with the MAINT / BUILD / CI updates from main to start fixing such issues.