[ENH] Fix incorrect PMF plotting #714
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #416. See also #415.
What does this implement/fix? Explain your changes.
Fixes incorrect PMF plotting for discrete distributions. Previously, discrete distributions like Binomial were plotted as continuous curves. Now they correctly display as discrete probability mass functions using stem plots at integer support points.
Changes:
_plot_single()inBaseDistributionto detect discrete distributionsDoes your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Yes, added
test_discrete_pmf_plotting()intest_proba_basic.pyto verify stem plots are used for discrete PMF.Any other comments?
Maintains full backward compatibility with existing continuous distribution plotting.
PR checklist
For all contributions
For new estimators
dependency isolation, see the
estimator dependencies guide.