-
Notifications
You must be signed in to change notification settings - Fork 77
[ENH] distributions: move parameters for Monte Carlo approximations to configs #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
- please add tests, if possible
- this PR also seems to contain #650 which is probably an oversight? Simply revert changes related to
_sample. Since PR get squashed, it will not affect the other PR.
|
Okay, thank you. will add the test as requested |
13e256a to
e9d13db
Compare
|
I have removed the oversight PR and included the test. Is there a reason why it's failing in the pipeline? Checked, and seems it's based on code quality |
|
Seems it's passed now. A "." - fullstop, was the cause. |
|
@fkiraly is there a code compatibility rule to follow which will allow the test to pass? |
|
as the log says at the end, have a look at the log for that, you can click on the failed test job |
|
Thanks. Apparently it didn't pass because no new line was included after the last line of the test. |
|
it still does not pass |
|
@fkiraly it passes again now. If it's okay to merge now, let me now, so i can squash and remove the unnecessary commit. |
|
Hi, @fkiraly what needs to be done or corrected to get this merged? |
Reference Issues/PRs
Fixes #269
What does this implement/fix? Explain your changes.
Provided options for Monte Carlo approximations parameters to be overriden via _configs
e.g
dist.set_config(approx_mean_spl=5)Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Correctness of Implementation
Also how else we can place the Monte Carlo parameters (for better code readability)
Did you add any tests for the change?
No
Any other comments?
We might need to modify the distribution test (or write one) to check for the overriden configs.
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.