Skip to content

Conversation

@smilingprogrammer
Copy link
Contributor

Reference Issues/PRs

Fixes #269

What does this implement/fix? Explain your changes.

Provided options for Monte Carlo approximations parameters to be overriden via _configs
e.g dist.set_config(approx_mean_spl=5)

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Correctness of Implementation
Also how else we can place the Monte Carlo parameters (for better code readability)

Did you add any tests for the change?

No

Any other comments?

We might need to modify the distribution test (or write one) to check for the overriden configs.

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

  • please add tests, if possible
  • this PR also seems to contain #650 which is probably an oversight? Simply revert changes related to _sample. Since PR get squashed, it will not affect the other PR.

@smilingprogrammer
Copy link
Contributor Author

Okay, thank you. will add the test as requested

@smilingprogrammer
Copy link
Contributor Author

smilingprogrammer commented Nov 28, 2025

I have removed the oversight PR and included the test. Is there a reason why it's failing in the pipeline?
Or is there a code compatibility guide to follow?

Checked, and seems it's based on code quality

@smilingprogrammer
Copy link
Contributor Author

Seems it's passed now. A "." - fullstop, was the cause.

@smilingprogrammer
Copy link
Contributor Author

@fkiraly is there a code compatibility rule to follow which will allow the test to pass?

@fkiraly
Copy link
Collaborator

fkiraly commented Nov 29, 2025

as the log says at the end, have a look at the log for that, you can click on the failed test job

@smilingprogrammer
Copy link
Contributor Author

Thanks. Apparently it didn't pass because no new line was included after the last line of the test.

@fkiraly
Copy link
Collaborator

fkiraly commented Dec 8, 2025

it still does not pass

@smilingprogrammer
Copy link
Contributor Author

@fkiraly it passes again now.
Somehow the problems is always from characters (no new lines, comment character exceeding lines, e.t.c)

If it's okay to merge now, let me now, so i can squash and remove the unnecessary commit.

@smilingprogrammer
Copy link
Contributor Author

Hi, @fkiraly what needs to be done or corrected to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement module:probability&simulation probability distributions and simulators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] distributions: move parameters for Monte Carlo approximations to configs

2 participants