fix(be): upgrade node to v22 to use esmodule in nestjs#2681
Merged
dotoleeoak merged 4 commits intomainfrom Apr 10, 2025
Merged
Conversation
This reverts commit 49f4891.
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (5)
- .devcontainer/Dockerfile: Language not supported
- .gitpod.Dockerfile: Language not supported
- .nvmrc: Language not supported
- apps/backend/Dockerfile: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:264
- The smoke test instructions are currently only in comments; consider implementing an actual smoke test to verify backend health automatically.
# TODO: write smoke test for backend
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#2677 에서 graphql-upload를 v17로 업그레이드하였는데, pure-esm만 지원하는 모듈로 현재 x86 환경에서 아래와 같은 에러가 발생합니다. NestJS는 pure-esm을 지원하지 않아 발생하는 문제입니다. (관련 이슈: nestjs/nest#8736)
Node.js v22.12.0에 도입된
require(esm)지원을 적용합니다.nodejs/node#55085
Additional context
Node.js 버전을 더 분명히 하도록 .nvmrc와 package.json의 engines 필드를 추가하였습니다.
Before submitting the PR, please make sure you do the following
fixes #123).