Skip to content

New settings structure, migrate to toml configs#956

Merged
dmytrotkk merged 10 commits intodevelopfrom
update-settings-structure
Feb 16, 2026
Merged

New settings structure, migrate to toml configs#956
dmytrotkk merged 10 commits intodevelopfrom
update-settings-structure

Conversation

@dmytrotkk
Copy link
Collaborator

This pull request standardizes the use of config_file as the primary configuration argument throughout the CLI codebase, replacing the previous env_file and env_filepath usages. It also updates developer instructions to reflect new tooling and environment requirements, introduces settings file paths, and improves type handling for environment types. These changes improve consistency, maintainability, and developer experience.

CLI argument standardization and refactoring:

  • Replaced all env_file/env_filepath CLI arguments and parameters with config_file across node_cli/cli/node.py, node_cli/cli/fair_node.py, and node_cli/cli/passive_fair_node.py, updating function signatures and internal usages accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]

  • Updated the restore command for schains to use settings from get_settings() and explicitly pass schain_type and env_type, removing the --env-type option.

Developer instructions and tooling:

  • Updated .github/copilot-instructions.md to reference pyproject.toml for formatting, require use of uv run for all commands (including linting and tests), and added instructions for exporting environment variables before running tests.

Configuration and settings improvements:

  • Added new settings file paths (SETTINGS_DIR, NODE_SETTINGS_PATH, INTERNAL_SETTINGS_PATH) to node_cli/configs/__init__.py for future configuration management.

  • Cleaned up unused or legacy configuration variables and imports in node_cli/configs/__init__.py. [1] [2]

Type and import enhancements:

  • Replaced usage of ALLOWED_ENV_TYPES with dynamic extraction of allowed types from EnvType using get_args in CLI argument definitions, improving type safety and maintainability. [1] [2] [3]

  • Added missing imports for new settings and type handling. [1] [2]

@dmytrotkk dmytrotkk requested review from a team, badrogger and kladkogex as code owners February 16, 2026 11:10
@dmytrotkk dmytrotkk self-assigned this Feb 16, 2026
@dmytrotkk dmytrotkk requested a review from alexgex February 16, 2026 11:10
@dmytrotkk dmytrotkk linked an issue Feb 16, 2026 that may be closed by this pull request
@dmytrotkk dmytrotkk merged commit cdd64e4 into develop Feb 16, 2026
2 checks passed
@dmytrotkk dmytrotkk deleted the update-settings-structure branch February 16, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate configs to the pydantic-settings

2 participants

Comments