[FEAT]: Add stream events#117
Open
Doominika wants to merge 35 commits intoandroid-stream-api-testingfrom
Open
Conversation
… feat/add-stream-events # Conflicts: # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/modules/stream/JanusPublisher.java
… feat/add-stream-events # Conflicts: # settings.gradle
djenczewski
reviewed
Feb 13, 2026
| @@ -208,26 +203,27 @@ public StreamPublishResult updateStream( | |||
|
|
|||
|
|
|||
| // todo | |||
Member
There was a problem hiding this comment.
Is this still something that needs to be done?
djenczewski
reviewed
Feb 13, 2026
| @@ -189,12 +189,7 @@ public native StreamHandle createStream( | |||
| public native StreamPublishResult publishStream(StreamHandle streamHandle); | |||
|
|
|||
| // todo | |||
Member
There was a problem hiding this comment.
Is this still something that needs to be done?
djenczewski
reviewed
Feb 13, 2026
|
|
||
| import java.util.List; | ||
|
|
||
| public class NewStreams { |
Member
There was a problem hiding this comment.
fields in all event data classes can be final
djenczewski
reviewed
Feb 13, 2026
|
|
||
| // todo: which to choose | ||
| // same as StreamPublishedEventData | ||
| public class StreamPublishedEventData { |
Member
There was a problem hiding this comment.
Maybe make it as extension for PublishedStreamData
djenczewski
reviewed
Feb 13, 2026
| ) { | ||
| JniContextUtils ctx(env); | ||
| jobject result; | ||
|
|
Member
There was a problem hiding this comment.
add nullcheck for stream_handle
djenczewski
reviewed
Feb 13, 2026
Member
There was a problem hiding this comment.
this comment can be deleted?
djenczewski
reviewed
Feb 13, 2026
| ) { | ||
| jclass cls = ctx->FindClass( | ||
| "com/simplito/java/privmx_endpoint/model/events/StreamEventData"); | ||
| jmethodID ctor = ctx->GetMethodID( |
djenczewski
requested changes
Feb 13, 2026
Member
djenczewski
left a comment
djenczewski
left a comment
There was a problem hiding this comment.
- Maybe streams parsers can be move to one parser file, after change distribution
- StreamSettingsJni should be in streams for desktop jni not for base StreamApiLow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.