refactor(tests): min go 1.23, golangci-lint 2.5.0, linter advices

[FranciscoKurpiel]

This pull request introduces a series of updates and improvements to the codebase, focusing on dependency updates, testing enhancements, and general code hygiene.

CI/CD

• Go Version: The Go version used in the CI workflow has been upgraded from 1.22 to 1.23. This allows us to leverage the latest features and improvements in the Go language.
• golangci-lint: The version of golangci-lint has been updated from v2.1.6 to v2.5.0. This brings in new linting rules and bug fixes, helping to improve code quality.

Testing

• Context Handling: In the test files, all instances of context.Background() have been replaced with t.Context(). This is a significant improvement in our testing practices. t.Context() provides a context that is automatically canceled when the test or subtest completes, preventing resource leaks from dangling goroutines and making the tests more robust.
• Test Assertion Fix: A bug in the TestUpdate function within client_test.go has been resolved. Previously, the originalComment and changedComment variables were identical, meaning the test was not correctly verifying the update functionality. This has been corrected to ensure the test is effective.
• Loop Variable Handling: The //nolint:copyloopvar directive has been removed from the TestConflict function. This is now possible due to the improved handling of loop variables in Go 1.22 and later.

Other Changes

• Go Module: The go.mod file has been updated to reflect the new Go version (1.23.0) and the toolchain directive has been removed.
• Code Formatting: Various minor code formatting adjustments have been made throughout the codebase to improve readability and maintain consistency.
• Documentation: A minor typo in a function comment in listzones.go has been corrected.

[gemini-code-assist]

Summary of Changes

Hello @FranciscoKurpiel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates various test files to utilize t.Context() instead of context.Background(). This change is a significant step towards improving test hygiene and reliability by ensuring that contexts used within tests are properly managed and automatically canceled upon test completion. This prevents resource leaks and enhances the overall robustness of the test suite, particularly when tests are run with timeouts.

Highlights

• Modernizing Go Test Context Usage: Replaced all instances of context.Background() with t.Context() within test files to align with modern Go (1.20+) testing best practices.
• Improved Test Hygiene and Robustness: The use of t.Context() ensures that contexts are automatically canceled when a test or subtest completes, preventing potential resource leaks from dangling goroutines and making test execution more robust, especially with timeouts.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly refactors the test files to use t.Context() instead of context.Background(). This is a good change that aligns with modern Go testing practices, improving test robustness by ensuring contexts are canceled when tests complete. The implementation is correct across all modified files. While reviewing, I noticed a pre-existing issue in one of the modified tests that could be improved, and I've left a comment with the details.