Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 37.60% 37.60%
=======================================
Files 37 37
Lines 11540 11540
=======================================
Hits 4340 4340
Misses 7200 7200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Do we know that the x86 wheels actually work? Is anyone still using an x86 mac? They are stopping updates for those as of 2026. |
Then let's stop supporting them as well. |
|
I'm happy with that. |
|
Sounds good, merging |
.github/workflows/build.yml
Outdated
| CIBW_TEST_EXTRAS: "test" | ||
| CIBW_ENVIRONMENT: "PIP_ONLY_BINARY=h5py" | ||
| CIBW_BEFORE_TEST_MACOS: "pip install --no-binary ducc0 ducc0" | ||
| CIBW_TEST_SKIP: "*-macosx_x86_64" |
There was a problem hiding this comment.
Is it a good idea to skip these? Do you know why they fail?
There was a problem hiding this comment.
Yes, numba does not support macOS x86 starting from Jan 2026. This cause issues with the llvmlite versions installed and the latest numba version. If we wanted to maintain macOS x86 support we need to pin numba to a version older than 0.63. Also there was no need to rerun the tests since the build depended on the tests passing.
No description provided.