Skip to content

Fixing workflows#329

Merged
msyriac merged 10 commits intomasterfrom
fix/workflows
Feb 4, 2026
Merged

Fixing workflows#329
msyriac merged 10 commits intomasterfrom
fix/workflows

Conversation

@iparask
Copy link
Member

@iparask iparask commented Jan 29, 2026

No description provided.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.60%. Comparing base (e5fa1e0) to head (d2ad2d4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   37.60%   37.60%           
=======================================
  Files          37       37           
  Lines       11540    11540           
=======================================
  Hits         4340     4340           
  Misses       7200     7200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iparask iparask requested a review from msyriac February 3, 2026 17:40
@iparask iparask requested a review from JBorrow February 3, 2026 20:12
@JBorrow
Copy link
Member

JBorrow commented Feb 4, 2026

Do we know that the x86 wheels actually work? Is anyone still using an x86 mac? They are stopping updates for those as of 2026.

@iparask
Copy link
Member Author

iparask commented Feb 4, 2026

Do we know that the x86 wheels actually work? Is anyone still using an x86 mac? They are stopping updates for those as of 2026.

Then let's stop supporting them as well. numba stopped supporting them. I'll remove the whole x86 part of the workflow.

@JBorrow
Copy link
Member

JBorrow commented Feb 4, 2026

I'm happy with that.

@msyriac
Copy link
Member

msyriac commented Feb 4, 2026

Sounds good, merging

CIBW_TEST_EXTRAS: "test"
CIBW_ENVIRONMENT: "PIP_ONLY_BINARY=h5py"
CIBW_BEFORE_TEST_MACOS: "pip install --no-binary ducc0 ducc0"
CIBW_TEST_SKIP: "*-macosx_x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a good idea to skip these? Do you know why they fail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, numba does not support macOS x86 starting from Jan 2026. This cause issues with the llvmlite versions installed and the latest numba version. If we wanted to maintain macOS x86 support we need to pin numba to a version older than 0.63. Also there was no need to rerun the tests since the build depended on the tests passing.

@msyriac msyriac merged commit a3dd67a into master Feb 4, 2026
20 checks passed
@iparask iparask deleted the fix/workflows branch February 4, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants