Skip to content

Conversation

@Blayung
Copy link
Contributor

@Blayung Blayung commented Jan 31, 2026

Update Asset directory functionality to recursively search the directory and call apk.addFileInput for each file

Fixes #62

@silbinarywolf
Copy link
Owner

Test your changes before raising a PR please. This code is failing tests at compile-time

@Blayung
Copy link
Contributor Author

Blayung commented Jan 31, 2026

Sorry, I forgot to try to compile an example. It should work now but the github CI was cancelled for some reason.

@silbinarywolf
Copy link
Owner

Sorry, I forgot how to properly test a library. It should work now but the github CI was cancelled for some reason.

Its failing on Zig 0.16.X (current master), as per the Mac CI build info. (If one platform fails, it cancels the other builds)

To be cross-compatible need changes like this:

const cwd = if (builtin.zig_version.major == 0 and builtin.zig_version.minor <= 15)
    try std.fs.cwd()
else
    try std.Io.Dir.cwd()

From Zig 0.16.X onwards too, most the function calls require an Io interface, which can be obtained from std.Build via g.b.graph.io

@silbinarywolf
Copy link
Owner

awesome, thank you!

@silbinarywolf silbinarywolf changed the title Fixed #62 Update Asset directory functionality to recursively search the directory and call apk.addFileInput for each file #62 Feb 2, 2026
@silbinarywolf silbinarywolf changed the title Update Asset directory functionality to recursively search the directory and call apk.addFileInput for each file #62 Update Asset directory functionality to recursively search the directory and call apk.addFileInput for each file Feb 2, 2026
@silbinarywolf silbinarywolf merged commit 3c2051b into silbinarywolf:main Feb 2, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Asset directory functionality to recursively search the directory and call apk.addFileInput for each file

2 participants