Skip to content

Conversation

@si
Copy link
Owner

@si si commented Jan 27, 2026

Optimize eleventy-plugin-local-images to skip JSDOM when unnecessary

Implemented a fast-path optimization that performs a case-insensitive regex check for relevant tags (images, metadata) before instantiating JSDOM. This avoids heavy DOM parsing on pages that do not contain images. The optimization is scoped to known selectors to maintain backward compatibility with custom configurations.

Benchmark results:

  • No Images: ~71ms -> ~0.3ms per iteration (~230x speedup)
  • With Images: Logic verified to remain functional.

PR created automatically by Jules for task 5978649643787595112 started by @si

Implemented a fast-path optimization that performs a case-insensitive regex check for relevant tags (images, metadata) before instantiating JSDOM. This avoids heavy DOM parsing on pages that do not contain images. The optimization is scoped to known selectors to maintain backward compatibility with custom configurations.

Benchmark results:
- No Images: ~71ms -> ~0.3ms per iteration (~230x speedup)
- With Images: Logic verified to remain functional.

Co-authored-by: si <18108+si@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
11ty f8d8e05 Jan 27 2026, 08:57 AM

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for sijobling ready!

Name Link
🔨 Latest commit f8d8e05
🔍 Latest deploy log https://app.netlify.com/projects/sijobling/deploys/69787de9cf1b3b0008fd1246
😎 Deploy Preview https://deploy-preview-28--sijobling.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants