added to allow for two mod sources, mod0 and mod1#267
Open
koltenpearson wants to merge 1 commit intoshorepine:mainfrom
Open
added to allow for two mod sources, mod0 and mod1#267koltenpearson wants to merge 1 commit intoshorepine:mainfrom
koltenpearson wants to merge 1 commit intoshorepine:mainfrom
Conversation
Collaborator
|
Nice! We'll take a look. |
Collaborator
|
Nice work. I am curious about the 2 LFO use case - is it for pitch and envelope at separate rates or something like that? |
Author
|
Yes being able to change both pitch and amplitude/pwm on the same oscillator is the use case I had in mind. It is more for me to experiment with than achieve a specific sound. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the project I am working on I wanted the ability to have 2 LFOs so I went ahead and added support for it.
If this is not desired then no worries, go ahead and close it.
If this is desired then note I only made the minimal number of changes to support my use case. Specifically I did not try to support python, and I imagine it breaks the examples and tests. I figured I would wait and see if this was wanted before going any farther.
I am willing to add support to the python bindings examples and tests, though I will probably need a little guidance on how you would want the syntax and argument names to be in the interest of backwards compatibility and whatnot.