feat(cms-base-layer): improve image performance and add ISR support#2287
Draft
Maciek Kucmus (mkucmus) wants to merge 6 commits intomainfrom
Draft
feat(cms-base-layer): improve image performance and add ISR support#2287Maciek Kucmus (mkucmus) wants to merge 6 commits intomainfrom
Maciek Kucmus (mkucmus) wants to merge 6 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
vercel
bot
temporarily deployed
to
Preview – shopware-frontends-docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
srcset/sizesto CMS images via provide/inject (CmsGenericBlock → CmsElementImage)srcsetusing CDN query params when no thumbnails exist (generateCdnSrcSet,buildCdnImageUrlin @shopware/helpers)fetchpriority="high"to LCP image preloadimageSizesmapping inapp.config.tswithgetImageSizeshelperType of change
ToDo's
Screenshots (if applicable)
Additional context