Open
Conversation
|
This is a decent PR. I actually just came here to implement this and was happy to see that someone beat me to it. |
|
Can we please have this merged and released to npm @shime ? |
|
Actually this PR is broken. It does not work. The reason why is because 0e8b97f#diff-2f062de8635f61fbec7693ba8f7bdc5dd196f7e694240826c4b304a1e83baff3 is referencing a file path. You cannot do this. The actual file must be included, similar to Zepto. @shime if you give me PR/GitHub/npm access we will fix this properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #34.
This is just the bare minimum to get it working, I haven't added any config options to opt out or anything like that.