Draft
Conversation
Integrates MegaETH as a second-class citizen chain following the established pattern. **Packages:** - Add MegaETH chain/asset constants and references to @shapeshiftoss/caip - Add MegaEthMainnet to KnownChainIds enum in @shapeshiftoss/types - Create MegaETH chain adapter extending SecondClassEvmAdapter - Add MegaETH to evmChainIds, ChainSpecific types, and base utilities - Add megaethAssetId to FEE_ASSET_IDS array - Define viem client for MegaETH (chain ID 4326) **Application:** - Create MegaETH plugin with chain adapter registration - Add MegaEth feature flag to preferences slice - Add VITE_MEGAETH_NODE_URL and VITE_FEATURE_MEGAETH to config - Add MegaETH CSP headers for RPC endpoint - Add MegaETH to AssetService feature flag filter - Add MegaETH support to wallet compatibility hooks - Add MegaETH to portfolioSlice utilities (accountIdToLabel, isAssetSupportedByWallet) **Dependencies:** - Upgrade viem from 2.40.3 to 2.43.5 **Notes:** - Currently targeting testnet (Chain ID 4326 - Frontier) - TODO markers added for mainnet migration when whitelisted - Type errors for supportsMegaEth expected until hdwallet-core published
Update all @shapeshiftoss/hdwallet-* packages to 1.62.35-megaeth.0 from local verdaccio registry.
Add VITE_MEGAETH_NODE_URL and VITE_FEATURE_MEGAETH to: - .env (feature flag disabled by default) - .env.development (feature flag enabled for dev)
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add explicit formatting rules from ESLint/Prettier config to avoid future lint diffs: - Single quotes, no semicolons - 100 char line width, trailing commas - Arrow function parens rules - Named exports only (except stories/test mocks) - Type import preferences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Web fren of shapeshift/hdwallet#778
TODO: switch to MegaETH mainnet and test me
Issue (if applicable)
N/A
Risk
TODO
TODO
Testing
Engineering
TODO
Operations
TODO
Screenshots (if applicable)
TODO