This repository was archived by the owner on Apr 11, 2023. It is now read-only.
feat: remove dead investor-foxy code#1130
Draft
gomesalexandre wants to merge 1 commit intofeat_foxy_rename_amountDesired_amountDesiredCryptoBaseUnitfrom
Draft
feat: remove dead investor-foxy code#1130gomesalexandre wants to merge 1 commit intofeat_foxy_rename_amountDesired_amountDesiredCryptoBaseUnitfrom
gomesalexandre wants to merge 1 commit intofeat_foxy_rename_amountDesired_amountDesiredCryptoBaseUnitfrom
Conversation
3 tasks
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
gomesalexandre
changed the base branch from
feat_investor_foxy_ethers_js_batch_provider
to
feat_foxy_rename_amountDesired_amountDesiredCryptoBaseUnit
gomesalexandre
force-pushed
the
chore_rm_foxy_dead_code
branch
from
e41d0ac to
b63b082
Compare
gomesalexandre
force-pushed
the
feat_foxy_rename_amountDesired_amountDesiredCryptoBaseUnit
branch
from
be49931 to
5c89623
Compare
gomesalexandre
force-pushed
the
chore_rm_foxy_dead_code
branch
from
b63b082 to
8b7c743
Compare
gomesalexandre
force-pushed
the
feat_foxy_rename_amountDesired_amountDesiredCryptoBaseUnit
branch
from
5c89623 to
7d937ee
Compare
gomesalexandre
force-pushed
the
chore_rm_foxy_dead_code
branch
from
8b7c743 to
e1f47e0
Compare
0xApotheosis
approved these changes
Jan 12, 2023
Member
0xApotheosis
left a comment
0xApotheosis
left a comment
There was a problem hiding this comment.
If CI passes on opening this, this looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes dead chonky block of investor-foxy code
Testing
Confirm investor-foxy is less chonky and code is actual dead (a.k.a CI should pass)