Return a slice when querying contents of a typed array#705
Open
simonwuelker wants to merge 1 commit intoservo:mainfrom
Open
Return a slice when querying contents of a typed array#705simonwuelker wants to merge 1 commit intoservo:mainfrom
simonwuelker wants to merge 1 commit intoservo:mainfrom
Conversation
This makes out-of-bounds access to typed arrays harder to do by accident. Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
sagudev
approved these changes
Feb 16, 2026
Member
sagudev
left a comment
sagudev
left a comment
There was a problem hiding this comment.
LGTM, but such change should get companion PR in servo before landing (so we do not land something that borks servo).
CI is blocked by jidicula/clang-format-action#267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rust there is no need to pass
(*mut T, usize)around, as that is just a*mut [T]. This makes out-of-bounds access to typed arrays harder to do by accident.Testing: Behaviour should be unchanged, no new tests are written