Added Glue for Functions with mozilla::Range Parameters#434
Open
redfire75369 wants to merge 7 commits intoservo:mainfrom
Open
Added Glue for Functions with mozilla::Range Parameters#434redfire75369 wants to merge 7 commits intoservo:mainfrom
mozilla::Range Parameters#434redfire75369 wants to merge 7 commits intoservo:mainfrom
Conversation
Member
|
Would it be possible to also add test for |
Contributor
Author
|
The errors seem to be caused by a C++ ABI issue, which is annoying, as per usual. The moment the |
redfire75369
force-pushed
the
mozilla-range
branch
from
662e50a to
ac557db
Compare
redfire75369
changed the title
Range::new to take Raw Pointersmozilla::Range Parameters
redfire75369
force-pushed
the
mozilla-range
branch
from
7afbd9c to
47ca02c
Compare
sagudev
reviewed
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to #433.
slice::as_mut_ptr_rangegives aRange<*mut T>, which would need to be converted to a reference to be used.