Open
Conversation
dimitryzub
requested review from
ilyazub,
jvmvik,
kagermanov27 and
ritu1337
ilyazub
reviewed
Sep 22, 2022
Contributor
ilyazub
left a comment
ilyazub
left a comment
There was a problem hiding this comment.
Thanks, @dimitryzub! Let's pair on this PR and mirror changes to serpapi/serpapi-python#1.
Contributor
Author
|
@ilyazub would love to do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on:
fix typos.
remove duplicates, for example:
text formatting, clarification.
remove unnecessary examples, or possibly leave them but with details disclosure element.
add backlinks to some terms.
add pagination examples for all available APIs.
Pagination examples could be placed to
oobt/folder instead to test "out of the box tests" for all APIs. However, I'm not familiar with it and how things currently work so I need a little guidance before working on it 🙂