Composite State Store part 3: Read path implementation #2756
+458
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/evm-ss-database #2756 +/- ##
===========================================================
+ Coverage 47.78% 47.81% +0.03%
===========================================================
Files 357 357
Lines 34697 34697
===========================================================
+ Hits 16581 16592 +11
+ Misses 16536 16527 -9
+ Partials 1580 1578 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Adds CompositeStateStore that routes reads between Cosmos_SS and EVM_SS: - Get/Has: Check EVM_SS first for EVM keys, fallback to Cosmos_SS - Iterator/ReverseIterator: Use Cosmos_SS (source of truth) - Uses commonevm.ParseEVMKey directly for key parsing Write methods delegate to Cosmos_SS only in this PR. Full dual-write implementation in next PR.
Kbhat1
force-pushed
the
feature/composite-ss-read-path
branch
from
b437822 to
f5ac4df
Compare
Kbhat1
force-pushed
the
feature/evm-ss-database
branch
from
7271005 to
7ef1b00
Compare
yzang2019
reviewed
Jan 26, 2026
| if s.evmStore != nil && storeKey == evm.EVMStoreKey { | ||
| storeType, strippedKey := commonevm.ParseEVMKey(key) | ||
| if storeType != evm.StoreUnknown { | ||
| db := s.evmStore.GetDB(storeType) |
Contributor
There was a problem hiding this comment.
Shouldn't we just call EVMStore.Get since EVMStore is supposed to manage all DBs? why do we need to get the actual db from it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change