Composite State Store Part 2: EVM database implementation #2755

Kbhat1 · 2026-01-23T21:38:46Z

Describe your changes and provide context

EVMDatabase: Single PebbleDB with DefaultComparer for each EVM data type
EVMStateStore: Manages multiple EVMDatabase instances (nonce, code, codehash, codesize, storage)
Versioned key encoding with big-endian version suffix
ApplyBatch and ApplyChangesetParallel for efficient concurrent writes
Uses commonevm.ParseMemIAVLEVMKey directly for key routing

Testing performed to validate your change

Unit tests

github-actions · 2026-01-23T21:39:45Z

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`✅ passed`	Jan 23, 2026, 10:09 PM

codecov · 2026-01-23T21:45:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.84%. Comparing base (0935d03) to head (7ef1b00).

Additional details and impacted files

@@                       Coverage Diff                        @@
##           feature/evm-ss-router-config    #2755      +/-   ##
================================================================
- Coverage                         41.86%   41.84%   -0.02%     
================================================================
  Files                              1022     1022              
  Lines                             84784    84784              
================================================================
- Hits                              35492    35479      -13     
- Misses                            45950    45957       +7     
- Partials                           3342     3348       +6

Flag	Coverage Δ
sei-cosmos	`37.72% <ø> (ø)`
sei-db	`68.72% <ø> (ø)`
sei-tendermint	`47.51% <ø> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 15 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sei-db/state_db/ss/evm/db.go

+	for keyStr, value := range keyValues {
+		if value != nil { // Skip tombstones
+			keys = append(keys, []byte(keyStr))
+			values = append(values, value)
+		}
+	}


sei-db/state_db/ss/evm/db.go

+	for storeType, pairs := range changes {
+		db := s.databases[storeType]
+		if db == nil {
+			continue
+		}
+		if err := db.ApplyBatch(pairs, version); err != nil {
+			return fmt.Errorf("failed to apply batch for %s: %w", StoreTypeName(storeType), err)
+		}
+	}


sei-db/state_db/ss/evm/db.go

+	for storeType, pairs := range changes {
+		db := s.databases[storeType]
+		if db == nil {
+			continue
+		}
+
+		wg.Add(1)
+		go func(db *EVMDatabase, pairs []*iavl.KVPair) {
+			defer wg.Done()
+			if err := db.ApplyBatch(pairs, version); err != nil {
+				errCh <- err
+			}
+		}(db, pairs)
+	}


sei-db/state_db/ss/evm/db.go

+	for _, db := range s.databases {
+		if v := db.GetLatestVersion(); v > maxVersion {
+			maxVersion = v
+		}
+	}


sei-db/state_db/ss/evm/db.go

+	for _, db := range s.databases {
+		if err := db.SetLatestVersion(version); err != nil {
+			return err
+		}
+	}


sei-db/state_db/ss/evm/db.go

+	for _, db := range s.databases {
+		v := db.GetEarliestVersion()
+		if minVersion < 0 || v < minVersion {
+			minVersion = v
+		}
+	}


sei-db/state_db/ss/evm/db.go

+	for _, db := range s.databases {
+		if err := db.SetEarliestVersion(version); err != nil {
+			return err
+		}
+	}


sei-db/state_db/ss/evm/db.go

+	for _, db := range s.databases {
+		if err := db.Prune(version); err != nil {
+			return err
+		}
+	}


sei-db/state_db/ss/evm/db.go

+	for _, db := range s.databases {
+		if err := db.Close(); err != nil {
+			lastErr = err
+		}
+	}


sei-db/state_db/ss/evm/db.go

+		go func(db *EVMDatabase, pairs []*iavl.KVPair) {
+			defer wg.Done()
+			if err := db.ApplyBatch(pairs, version); err != nil {
+				errCh <- err
+			}
+		}(db, pairs)


Adds the core EVM state store components: - EVMDatabase: Single PebbleDB with DefaultComparer for a specific EVM data type - EVMStateStore: Manages multiple EVMDatabase instances (nonce, code, codehash, codesize, storage) - Versioned key encoding with big-endian version suffix - ApplyBatch and ApplyChangesetParallel for efficient writes - EVMIterator for version-aware iteration over unique keys Uses commonevm.ParseEVMKey directly for key parsing (no router abstraction).

yzang2019 · 2026-01-26T21:00:46Z

sei-db/state_db/ss/evm/db.go

+func OpenEVMDB(dir string, storeType EVMStoreType) (*EVMDatabase, error) {
+	opts := &pebble.Options{
+		Comparer:           pebble.DefaultComparer,
+		MaxConcurrentCompactions: func() int { return 2 },


Is 2 enough or shall we bump to numCPU?

yzang2019 · 2026-01-26T21:03:10Z

sei-db/state_db/ss/evm/db.go

+func (db *EVMDatabase) SetLatestVersion(version int64) error {
+	buf := make([]byte, 8)
+	binary.BigEndian.PutUint64(buf, uint64(version))
+	if err := db.storage.Set([]byte(latestVersionKey), buf, syncWriteOpts); err != nil {


Do we really wanna sync here? This is gonna trigger fsync which could impact performance

yzang2019 · 2026-01-26T21:05:34Z

sei-db/state_db/ss/evm/db.go

+}
+
+// EVMStateStore manages multiple EVMDatabase instances, one per EVM data type
+type EVMStateStore struct {


Should this be moved to a separate file? I feel it would be cleaner if we keep db.go only containing the db related logic. And EVMStateStore seems to be a layer above that, since it needs to manage multiple dbs

yzang2019 · 2026-01-26T21:11:15Z

sei-db/state_db/ss/evm/db.go

+}
+
+// Prune removes old versions from all databases
+func (s *EVMStateStore) Prune(version int64) error {


Shall we parallelize this or have each DB run the pruning in the background?

Kbhat1 changed the title ~~Composite State Store part 2: EVM database implementation~~ Composite State Store Part 2: EVM database implementation Jan 23, 2026

Kbhat1 added the non-app-hash-breaking label Jan 23, 2026

github-advanced-security bot found potential problems Jan 23, 2026

View reviewed changes

Kbhat1 force-pushed the feature/evm-ss-router-config branch from ac83d2f to 0935d03 Compare January 23, 2026 22:08

Kbhat1 force-pushed the feature/evm-ss-database branch from 7271005 to 7ef1b00 Compare January 23, 2026 22:08

Kbhat1 requested review from blindchaser, jewei1997 and yzang2019 January 23, 2026 22:24

yzang2019 reviewed Jan 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Composite State Store Part 2: EVM database implementation #2755

Composite State Store Part 2: EVM database implementation #2755

Kbhat1 commented Jan 23, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check notice

yzang2019 Jan 26, 2026

Uh oh!

yzang2019 Jan 26, 2026

Uh oh!

yzang2019 Jan 26, 2026

Uh oh!

yzang2019 Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Composite State Store Part 2: EVM database implementation #2755

Are you sure you want to change the base?

Composite State Store Part 2: EVM database implementation #2755

Conversation

Kbhat1 commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes and provide context

Testing performed to validate your change

Uh oh!

github-actions bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check notice

yzang2019 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

yzang2019 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

yzang2019 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

yzang2019 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Kbhat1 commented Jan 23, 2026 •

edited

Loading

github-actions bot commented Jan 23, 2026 •

edited

Loading

codecov bot commented Jan 23, 2026 •

edited

Loading