Composite State Store part 1: EVM config and type definitions #2754
+134
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
==========================================
- Coverage 43.81% 43.81% -0.01%
==========================================
Files 1991 1992 +1
Lines 163571 163596 +25
==========================================
+ Hits 71672 71680 +8
- Misses 85378 85400 +22
+ Partials 6521 6516 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Kbhat1
force-pushed
the
feature/evm-ss-router-config
branch
from
630fbf3 to
ac83d2f
Compare
Kbhat1
changed the title
Adds configuration and type definitions for EVM state stores: - EVMStateStoreConfig in config/config.go for enabling EVM SS - EVMStoreType alias to EVMKeyKind from common/evm - AllEVMStoreTypes() for iteration over store types - StoreTypeName() for DB directory naming Also renames common/evm/memiavl_keys.go to keys.go and ParseMemIAVLEVMKey to ParseEVMKey for broader applicability.
Kbhat1
force-pushed
the
feature/evm-ss-router-config
branch
from
ac83d2f to
0935d03
Compare
yzang2019
reviewed
Jan 26, 2026
| type EVMStoreType = commonevm.EVMKeyKind | ||
|
|
||
| // Re-export EVMKeyKind constants for convenience | ||
| const ( |
Contributor
There was a problem hiding this comment.
Not sure if this belongs to config, maybe we should move the store types to another file?
| StoreNonce = commonevm.EVMKeyNonce | ||
| StoreCodeHash = commonevm.EVMKeyCodeHash | ||
| StoreCode = commonevm.EVMKeyCode | ||
| StoreCodeSize = commonevm.EVMKeyCodeSize |
Contributor
There was a problem hiding this comment.
I don't think we wanna store code size in the new EVM state any more, that's not part of the standard EVM state
jewei1997
reviewed
Jan 26, 2026
|
|
||
| // Re-export EVMKeyKind constants for convenience | ||
| const ( | ||
| StoreUnknown = commonevm.EVMKeyUnknown |
Contributor
There was a problem hiding this comment.
we don't need a key for Balance because we're using tendermint store for balances right?
Contributor
There was a problem hiding this comment.
We should still add it though I think, but won't be used until migration happens
jewei1997
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change