Delete topic settings from broker if they are not present in the topic config#198
Open
fpacifici wants to merge 6 commits intosegmentio:masterfrom
Open
Delete topic settings from broker if they are not present in the topic config#198fpacifici wants to merge 6 commits intosegmentio:masterfrom
fpacifici wants to merge 6 commits intosegmentio:masterfrom
Conversation
fpacifici
added a commit
to getsentry/topicctl
that referenced
this pull request
Jun 14, 2024
…tion Same as segmentio#198 This is a PR in our fork so we can merge it in master here and start working on that while the PR on upstream gets reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with issue #197.
The idea of this PR is to make topic apply a bit more declarative by supporting deletion of settings that are not present in config.
As this could be a calamity if done by mistake, the behavior is disabled by default. A CLI argument
--destructiveis supported in the apply subcommand. If that flag is not set, the behavior is the same as it was before.Example:
Typing
yesthe retetion.ms setting is deleted.If I run the command again there is no more diff to apply.
Test plan: