Add virtual address support to memory segments #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #13 +/- ##
===========================================
+ Coverage 92.60% 92.66% +0.05%
===========================================
Files 5 5
Lines 757 763 +6
===========================================
+ Hits 701 707 +6
Misses 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change enables SDB integration by allowing memory segments to have both physical and virtual addresses. When drgn loads a vmcore created with kdumpling, it can now read memory by virtual address directly. Changes: - Add virt_addr parameter to add_memory_segment() (defaults to phys_addr) - Add effective_virt_addr property to MemorySegment dataclass - Update _write_elf() to set p_vaddr in PT_LOAD headers - Update DumpStats to include virtual addresses in segment tuples - Add comprehensive tests for virtual address support - Add drgn integration tests for virtual address memory reading https://claude.ai/code/session_018wj4HefWHH9naQ29a4pwr8
sdimitro
force-pushed
the
claude/scope-kdumpling-sdb-ipBbR
branch
from
80c4332 to
d8584de
Compare
Document the new virt_addr parameter for add_memory_segment() with examples showing how to use it with drgn for virtual address reads. https://claude.ai/code/session_018wj4HefWHH9naQ29a4pwr8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables SDB integration by allowing memory segments to have
both physical and virtual addresses. When drgn loads a vmcore created
with kdumpling, it can now read memory by virtual address directly.
Changes:
https://claude.ai/code/session_018wj4HefWHH9naQ29a4pwr8