Conversation
Thank you for the pull request! ❤️The Scribe-Desktop team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-Desktop repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
Is there a way to switch the assignments here to be somehow dynamic? I worry about our ability to maintain this part of the code if we need to add in every key possible for every script 🤔 I think it's fine to merge this, but then actually leveraging a dependency that allows us to not need to maintain a list of characters would be great. Maybe the key assignment would be more assigning to a dictionary such that we'd be assigning it to a key rather than a direct variable, and the key could then be dynamically assigned based on keys from allowed characters? Just wondering :) |
andrewtavis
left a comment
There was a problem hiding this comment.
Thanks so much for the contribution here, @priyankaforu! Looking forward to working on this with you further :)
Contributor checklist
Description
There is a "." key missing in lib.rs. So I thought of adding it as I found it available in rdev
@henrikth93 and @andrewtavis , Please feel free to review it ! Thank you !!