Skip to content

fix: Added Period(.) Key#32

Merged
andrewtavis merged 1 commit intoscribe-org:mainfrom
priyankaforu:fix/Adding-period-key
Oct 11, 2025
Merged

fix: Added Period(.) Key#32
andrewtavis merged 1 commit intoscribe-org:mainfrom
priyankaforu:fix/Adding-period-key

Conversation

@priyankaforu
Copy link
Contributor

Contributor checklist

image

Description

There is a "." key missing in lib.rs. So I thought of adding it as I found it available in rdev

@henrikth93 and @andrewtavis , Please feel free to review it ! Thank you !!

@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Desktop team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Desktop rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Oct 11, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Desktop repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 11, 2025
@andrewtavis
Copy link
Member

Is there a way to switch the assignments here to be somehow dynamic? I worry about our ability to maintain this part of the code if we need to add in every key possible for every script 🤔 I think it's fine to merge this, but then actually leveraging a dependency that allows us to not need to maintain a list of characters would be great.

Maybe the key assignment would be more assigning to a dictionary such that we'd be assigning it to a key rather than a direct variable, and the key could then be dynamically assigned based on keys from allowed characters? Just wondering :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution here, @priyankaforu! Looking forward to working on this with you further :)

@andrewtavis andrewtavis merged commit 716a491 into scribe-org:main Oct 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted as a part of Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants