Add support for more types of leaderboards#11
Open
bswartz wants to merge 1 commit intosbezboro:masterfrom
Open
Add support for more types of leaderboards#11bswartz wants to merge 1 commit intosbezboro:masterfrom
bswartz wants to merge 1 commit intosbezboro:masterfrom
Conversation
With the 1.16 update of Minecraft, netherite is the new most valuable item, and the existing leaderboard systems don't allow players to compete in a meaningful way for netherite acquisition. This patch tracks 3 new events which are attempt to address this gap in different ways. Three new config options are added: * record-furnace-smelting - count smelted items removed from furnaces * record-crafting - count items crafted on workbenches and crafting grid * record-smithing - count items crafted on smithing tables The furnace smelting option allows counting the process of smelting ancient debris to netherite scraps. Due to limitations in bukkit, this event doesn't fire in every case you would want, and thus a leaderboard based on it can undercount, but it's still valuable. The crafting option allows reliable counting of creation of netherite ingots from scraps, although the code is somewhat complex. The crafting option also allows creation of leaderboards for any rare/valuable recipe, and this patch implements a few others. The smithing option allows counting of netherite items made from diamond items plus netherite ingots, to allow for specific leaderboards for individual tools/armor pieces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the 1.16 update of Minecraft, netherite is the new most valuable item,
and the existing leaderboard systems don't allow players to compete in a
meaningful way for netherite acquisition.
This patch tracks 3 new events which are attempt to address this gap in
different ways.
Three new config options are added:
The furnace smelting option allows counting the process of smelting
ancient debris to netherite scraps. Due to limitations in bukkit, this
event doesn't fire in every case you would want, and thus a leaderboard
based on it can undercount, but it's still valuable.
The crafting option allows reliable counting of creation of netherite
ingots from scraps, although the code is somewhat complex. The crafting
option also allows creation of leaderboards for any rare/valuable recipe,
and this patch implements a few others.
The smithing option allows counting of netherite items made from diamond
items plus netherite ingots, to allow for specific leaderboards for
individual tools/armor pieces.