ARM64: Critical userspace fixes (IPC wake, TTY pgrp, signal delivery) #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three critical fixes for ARM64 userspace functionality: 1. IPC Pipe Wake Mechanism (kernel/src/ipc/pipe.rs) - Removed #[cfg(target_arch = "x86_64")] gating around scheduler wake calls - ARM64 now properly wakes blocked readers when data is written - Added UNBLOCK_CALL_COUNT instrumentation to scheduler for testing 2. TTY Foreground Process Group (kernel/src/process/creation.rs) - ARM64 create_user_process() now sets foreground pgrp for console TTY - Enables Ctrl+C (SIGINT) delivery to foreground process - Test uses sentinel value detection to verify integration 3. Signal Delivery in Context Switch (kernel/src/arch_impl/aarch64/context_switch.rs) - Added check_and_deliver_signals_for_current_thread_arm64() - Proper SP_EL0 handling, TTBR0_EL1 switching with memory barriers - Made create_saved_regs_from_frame() public for testing - Test verifies all 35 register/field conversions All tests validated with APPROVE rating: - Technical Accuracy: A - Intellectual Honesty: A - Tests would fail if fixes reverted Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Three critical fixes for ARM64 userspace functionality, each with rigorous tests validated at A/A rating.
Changes
1. IPC Pipe Wake Mechanism
kernel/src/ipc/pipe.rs#[cfg(target_arch = "x86_64")]gating around scheduler wake callsUNBLOCK_CALL_COUNTatomic instrumentation to verifyscheduler.unblock()is called2. TTY Foreground Process Group
kernel/src/process/creation.rscreate_user_process()now sets foreground pgrp for console TTY0xDEAD_BEEFdetection with real process creation3. Signal Delivery in Context Switch
kernel/src/arch_impl/aarch64/context_switch.rscheck_and_deliver_signals_for_current_thread_arm64()(~174 lines)create_saved_regs_from_frame()Validation
All tests received APPROVE with:
Test Plan
Tests are in
kernel/src/test_framework/registry.rsand run automatically during ARM64 boot.🤖 Generated with Claude Code