feat: add wasm-bindgen feature for wasm#231
Open
Its-Just-Nans wants to merge 10 commits intorusticata:masterfrom
Open
feat: add wasm-bindgen feature for wasm#231Its-Just-Nans wants to merge 10 commits intorusticata:masterfrom
Its-Just-Nans wants to merge 10 commits intorusticata:masterfrom
Conversation
Author
|
note that the I can add that on this MR Edit: DONE |
cpu
previously approved these changes
Jan 30, 2026
Collaborator
cpu
left a comment
There was a problem hiding this comment.
Seems reasonable, but is there a way to add CI coverage so that support doesn't accidentally regress?
Author
yes, I will add that |
Author
|
Unfortunalty it's seems not possible because of the current MSRV Or i can add dymanicly in the CI the |
Its-Just-Nans
added a commit
to Its-Just-Nans/wombat
that referenced
this pull request
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR add the wasm-bindgen feature of the
timecrate on wasm https://docs.rs/crate/time/latest/featuresWithout the feature we have the error
Test file
cargo install wasm-pack cargo add --dev wasm-bindgen-test wasm-pack test --node