Add visitor pattern for Certification Request Info object and attributes#209
Open
Add visitor pattern for Certification Request Info object and attributes#209
Conversation
Member
Author
|
Note: please hold on review, this could conflict with #206 and will likely need a rebase. I'll update this PR |
chifflier
force-pushed
the
dev/visitor-cri-v0.1
branch
from
ea3e44f to
c7ec3a3
Compare
Member
Author
|
#206 is now merged, this is clean for review. Thanks! |
chifflier
force-pushed
the
dev/visitor-cri-v0.1
branch
from
c7ec3a3 to
675d96d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements visitor patterns for
X509CertificationRequestInfoandX509CriAttribute.It offers multiple (redundant) methods to allow accessing raw (unparsed) data and/or typed data (if parsed successfully).
References: #205 and #206