-
Notifications
You must be signed in to change notification settings - Fork 339
fix: match rulesets by branch pattern #2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dc38f6a to
1ca19d0
Compare
Dry-run check results |
1ca19d0 to
adac3d3
Compare
|
looks good. I did a few small changes. Testing in #2232 |
ubiratansoares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note from my side : perhaps we could have a follow-up PR to add some snapshot tests covering common scenarios around rulesets, eventually having #2211 as test case too 🙂
|
Ahmed, this is the diff of the dry run: It looks very verbose. Also, is it normal that it is deleting the ruleset and recreating it? |
Closes #2211
Summary
Improves ruleset diffing to match by branch pattern instead of name (enabling in-place updates rather than delete/recreate)