-
Notifications
You must be signed in to change notification settings - Fork 572
docs(ref): Specify frontmatter #1974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,58 @@ | ||||||||
| r[frontmatter] | ||||||||
| # Frontmatter | ||||||||
|
|
||||||||
| r[frontmatter.syntax] | ||||||||
| ```grammar,lexer | ||||||||
| @root FRONTMATTER -> | ||||||||
| FRONTMATTER_FENCE HORIZONTAL_WHITESPACE* INFOSTRING? HORIZONTAL_WHITESPACE* LF | ||||||||
| (FRONTMATTER_LINE LF )* | ||||||||
| FRONTMATTER_FENCE[^matched-fence] HORIZONTAL_WHITESPACE* LF | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a bit unusual to have load-bearing footnotes in the grammar. Would it be possible to define this recursively so that isn't necessary? Or is there maybe some other way around it?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just FYI, TC and I have been trying to come up with a grammar here, but we have not yet been able to land on something. I'm still working on it.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I worry that being too clever in encoding this could have a negative impact on users understanding this. Another route is to extend the grammar for inline context notes like how |
||||||||
|
|
||||||||
| FRONTMATTER_FENCE -> `-`{3..255} | ||||||||
|
|
||||||||
| INFOSTRING -> (XID_Start | `_`) ( XID_Continue | `-` | `.` )* | ||||||||
|
|
||||||||
| FRONTMATTER_LINE -> (~INVALID_FRONTMATTER_LINE_START (~INVALID_FRONTMATTER_LINE_CONTINUE)*)? | ||||||||
|
|
||||||||
| INVALID_FRONTMATTER_LINE_START -> (FRONTMATTER_FENCE[^escaped-fence] | CR | LF) | ||||||||
|
|
||||||||
| INVALID_FRONTMATTER_LINE_CONTINUE -> CR | LF | ||||||||
|
|
||||||||
| HORIZONTAL_WHITESPACE -> | ||||||||
| U+0009 // horizontal tab, `'\t'` | ||||||||
| | U+0020 // space, `' '` | ||||||||
| ``` | ||||||||
|
|
||||||||
| [^matched-fence]: The closing fence must have the same number of `-` as the opening fence | ||||||||
| [^escaped-fence]: A `FRONTMATTER_FENCE` at the beginning of a `FRONTMATTER_LINE` is only invalid if it has the same or more `-` as the `FRONTMATTER_FENCE` | ||||||||
|
|
||||||||
| r[frontmatter.intro] | ||||||||
| Frontmatter is an optional section for content intended for external tools without requiring these tools to have full knowledge of the Rust grammar. | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We always use "intro" for the introduction of something. Also, perhaps this intro could be moved to the top of the file?
Suggested change
Can you also include an example here?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
All other Lexical structure pages with a grammar open with the grammar. Most (but not all) other pages I randomly sampled did the same.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The into reference and an example were added
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CI identified two problems with the example
|
||||||||
|
|
||||||||
| ```rust | ||||||||
| #!/usr/bin/env cargo | ||||||||
| --- | ||||||||
| [dependencies] | ||||||||
| fastrand = "2" | ||||||||
| --- | ||||||||
|
|
||||||||
| fn main() { | ||||||||
| let num = fastrand::i32(..); | ||||||||
| println!("{num}"); | ||||||||
| } | ||||||||
| ``` | ||||||||
|
|
||||||||
| r[frontmatter.document] | ||||||||
| Frontmatter may only be preceded by a [shebang] and [whitespace]. | ||||||||
|
|
||||||||
| r[frontmatter.fence] | ||||||||
| The delimiters are referred to as a *fence*. The opening and closing fences must be at the start of a line. They must be a matching pair of hyphens (`-`), from 3 to 255. A fence may be followed by horizontal whitespace. | ||||||||
|
|
||||||||
| r[frontmatter.infostring] | ||||||||
| Following the opening fence may be an infostring for identifying the intention of the contained content. An infostring may be followed by horizontal whitespace. | ||||||||
|
|
||||||||
| r[frontmatter.body] | ||||||||
| The body of the frontmatter may contain any content except for a line starting with as many or more hyphens (`-`) than in the fences or carriage returns. | ||||||||
|
|
||||||||
| [shebang]: input-format.md#shebang-removal | ||||||||
| [whitespace]: whitespace.md | ||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two categories of feedback I am concerned about for this PR
Please keep in mind that I am not contributing to this for my own interest in the Reference (I was interested in that at one point but no longer) but to fulfill a requirement of another team.
How about an alternative route for this: this PR gets re-framed as a perma-draft that is a content dump without any editorial changes (changing the content to be as surgical as possible). Once we're agreed to the technical content, a T-reference person can then copy the commits, make any editorial changes they wish, and post their own PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone ahead and taken the approach of treating this PR as a way to share raw content that others can take and editorialize as they wish, making all of my changes surgical and making the PR un-editable.