feat(kompile): add \exists quantifiers for existential variables in add-module rules #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd-module rules When converting KRule to Kore axioms via add-module, variables that appear in RHS but not in LHS (existential variables) were not being wrapped with \exists quantifiers. This caused a structural difference compared to rules generated by kompile. This change adds two helper functions: - _collect_evars: collects all EVar instances from a Kore pattern - _add_exists_quantifiers: wraps RHS with \exists for each existential var The transformation is applied after krule_to_kore in _load_extra_module_rules.
dkcumming
approved these changes
Jan 21, 2026
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
I think this is all good, I am not familiar with your work for this though
automergerpr-permission-manager
bot
deleted the
jh/add-exists-quantifiers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.