refactor: delete total_count and remaining_count from pagination results#117
Merged
refactor: delete total_count and remaining_count from pagination results#117
Conversation
gautam-rl
reviewed
Feb 18, 2026
| items: pageBlueprints, | ||
| hasMore: page.has_more || false, | ||
| totalCount: page.total_count || pageBlueprints.length, | ||
| totalCount: pageBlueprints.length, |
There was a problem hiding this comment.
whats the effect of taking this || branch only - doesn't this affect how the UI shows the number of total results?
Contributor
Author
There was a problem hiding this comment.
should be no effect
66bb8b7 to
7a9b98e
Compare
c1eb746 to
9adc529
Compare
alb-rl
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: PR titles should follow Conventional Commits format (e.g.,
feat(devbox): add support for custom env varsorfix(snapshot): resolve pagination issue) as they are used for automatic release notes generation.Type of Change
Related Issues
Closes #
Changes Made
total_countandremaining_countfrom our API since it will be deprecated--limitoption tolistsubcommands ofblueprintsandsnapshotsTesting
Checklist
Screenshots (if applicable)
Additional Notes