fix: Update tests post-bun support; follows #115#116
Draft
Conversation
Add optional Bun support alongside existing pnpm/Node.js workflow: - Add Bun-specific scripts to package.json (dev:bun, start:bun, test:bun) - Apply stdin workaround in menu.tsx for Ink TUI compatibility with Bun - Update README.md with Bun development instructions - Update CONTRIBUTING.md with detailed Bun setup and usage - Add comprehensive investigation docs (BUN_MIGRATION_FINDINGS.md) - Add implementation guide (BUN_IMPLEMENTATION_GUIDE.md) - Add TUI testing guide (TEST_BUN_TUI.md) - Include test files for Bun+Ink compatibility verification The workaround (process.stdin.resume()) addresses Bun issue #6862 and enables full TUI functionality. Both CLI and TUI modes confirmed working with Bun 1.3.9. This is a non-breaking change - pnpm remains the default and primary package manager. Bun is offered as an optional faster alternative for contributors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add scripts to build standalone executables with Bun: - build:exe - Build for current platform - build:exe:macos, build:exe:linux, build:exe:windows - Platform-specific - build:exe:all - Build for all platforms Note: Currently experimental due to Bun bundler limitations with Ink's yoga-layout dependency. Runtime version works perfectly. Also updated: - .gitignore to exclude built executables - README.md with executable build instructions and caveat - CONTRIBUTING.md with detailed build info and known limitations
Add build-executables job to release workflow that: - Builds executables for all 5 platforms (macOS arm64/x64, Linux x64/arm64, Windows x64) - Uses Bun cross-compilation to build from single runner - Generates checksums for all built executables - Uploads executables as release assets - Adds installation instructions to release notes - Handles build failures gracefully (current Bun/Ink limitation) Workflow triggers when release-please creates a new release on main branch. Once Bun resolves the yoga-layout bundling issue, executables will automatically be built and attached to all future releases.
Update BUN_IMPLEMENTATION_GUIDE.md to document the new GitHub Actions workflow that builds executables on release.
…udes tests Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This reverts commit 74d032b.
Co-authored-by: Cursor <cursoragent@cursor.com>
tode-rl
changed the title
tode-rl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: PR titles should follow Conventional Commits format (e.g.,
feat(devbox): add support for custom env varsorfix(snapshot): resolve pagination issue) as they are used for automatic release notes generation.Type of Change
Related Issues
Closes #
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes