Skip to content

Comments

Update the github action for deploy agent to use SDK and add version string for agent#3

Merged
wall-rl merged 1 commit intomainfrom
wall-version
Dec 16, 2025
Merged

Update the github action for deploy agent to use SDK and add version string for agent#3
wall-rl merged 1 commit intomainfrom
wall-version

Conversation

@wall-rl
Copy link
Contributor

@wall-rl wall-rl commented Dec 16, 2025

No description provided.

@wall-rl wall-rl merged commit 30f9a38 into main Dec 16, 2025
1 check passed
Copy link
Contributor

@jrvb-rl jrvb-rl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one note - unless I missed something, making the version a required field means this is a breaking change. (or rather, the REST API change that made that required was a breaking change.).

This is probably fine since the SDKs are fairly new and probably have very few external users. We should be careful about this once these have been out in the wild longer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the dist/* files are auto-generated by pnpm build? Shouldn't we delete all of these in that case, since they will just create spurious noise in pull requests? Or do we need the .js files to all be there for the github action to work?

@wall-rl
Copy link
Contributor Author

wall-rl commented Dec 16, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants