Update the github action for deploy agent to use SDK and add version string for agent#3
Merged
Update the github action for deploy agent to use SDK and add version string for agent#3
Conversation
jrvb-rl
reviewed
Dec 16, 2025
Contributor
jrvb-rl
left a comment
There was a problem hiding this comment.
one note - unless I missed something, making the version a required field means this is a breaking change. (or rather, the REST API change that made that required was a breaking change.).
This is probably fine since the SDKs are fairly new and probably have very few external users. We should be careful about this once these have been out in the wild longer.
Contributor
There was a problem hiding this comment.
I assume the dist/* files are auto-generated by pnpm build? Shouldn't we delete all of these in that case, since they will just create spurious noise in pull requests? Or do we need the .js files to all be there for the github action to work?
Contributor
Author
|
Yea, for sure - we haven't released the agent api yet so this only broke
our demo we are using to "release" this api into the wild.
…On Mon, Dec 15, 2025 at 11:59 PM jrvb-rl ***@***.***> wrote:
***@***.**** commented on this pull request.
one note - unless I missed something, making the version a required field
means this is a breaking change. (or rather, the REST API change that made
that required was a breaking change.).
This is probably fine since the SDKs are fairly new and probably have very
few external users. We should be careful about this once these have been
out in the wild longer.
------------------------------
On dist/agent-deployer.js
<#3 (comment)>:
I assume the dist/* files are auto-generated by pnpm build? Shouldn't we
delete all of these in that case, since they will just create spurious
noise in pull requests? Or do we need the .js files to all be there for the
github action to work?
—
Reply to this email directly, view it on GitHub
<#3 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEELEG2JLF2ESUVZ2MBHA7L4B63UHAVCNFSM6AAAAACPEPYJFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOBRG43TCNRSGQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.